Code Review Vocabulary
Code reviews are daily at Western companies. Knowing the vocabulary helps you participate confidently.
Giving Feedback
- Nit / nitpick: "Nit: this variable name could be more descriptive." (minor suggestion)
- Blocking: "This is blocking — we cannot merge until the security issue is addressed."
- Suggestion: "Consider extracting this into a helper function for clarity."
- LGTM: "Looks Good To Me" — approving the PR
Receiving Feedback
- "Thanks for the feedback — I will refactor that method."
- "Good point — I missed that edge case."
- "I went with this approach because... but I am happy to change it."
PR Vocabulary
| Term | Meaning |
|---|
| PR / MR | Pull Request / Merge Request |
| diff | The set of changes in a PR |
| squash | Combining multiple commits into one |
| rebase | Replaying commits on top of another branch |